api support for sync job cancellation. #2717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screen.Recording.2024-11-11.at.12.24.05.PM.movScreen.Recording.2024-11-11.at.2.23.30.PM.mov |
MJ1998
requested changes
Jan 6, 2025
There was a problem hiding this comment.
One way to do this is to accept ExistingWorkPolicy in sync apis. Instead of ExistingWorkPolicy.KEEP if application provides ExistingWorkPolicy.REPLACE, workmanager library will cancel the current one and add new one with the same name.
Why not the above approach ?
jingtang10
reviewed
Jan 23, 2025
| @@ -42,12 +42,14 @@ import com.google.android.fhir.sync.CurrentSyncJobStatus.Succeeded | |||
| import com.google.gson.Gson | |||
| import com.google.gson.GsonBuilder | |||
| import java.time.OffsetDateTime | |||
| import java.util.* | |||
There was a problem hiding this comment.
pls don't use wildcards
jingtang10
approved these changes
Jan 23, 2025
MJ1998
reviewed
Jan 23, 2025
Comment on lines
+105
to
+117
| @PublishedApi | ||
| internal suspend fun storeWorkId(uuid: UUID, workIdKey: String) { | ||
| dataStore.edit { preferences -> | ||
| preferences[stringPreferencesKey("$workIdKey-key")] = uuid.toString() | ||
| } | ||
| } | ||
|
|
||
| /** Fetches the stored UUID from DataStore. */ | ||
| @PublishedApi | ||
| internal suspend fun fetchWorkId(workIdKey: String): UUID? { | ||
| val preferences = dataStore.data.first() | ||
| return preferences[stringPreferencesKey("$workIdKey-key")]?.let { UUID.fromString(it) } | ||
| } |
There was a problem hiding this comment.
Should there be some locking mechanism here?
What if both apis are triggered together for the same workIdKey ?
There was a problem hiding this comment.
Any specific use case which is tightly coupled with these api?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2695
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.